Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot configuration #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Oct 26, 2022

This PR configures dependabot for github actions, go, and cargo.

Likely a PR or two using github actions upcoming, might as well automatically maintain that too.

@faddat faddat mentioned this pull request Oct 26, 2022
@faddat
Copy link
Contributor Author

faddat commented Dec 22, 2024

@webmaster128 bump sir. It is a good idea to keep things up to date.

@faddat
Copy link
Contributor Author

faddat commented Feb 18, 2025

Really, it's good to keep things up to date.

@chipshort
Copy link
Collaborator

Libraries should specify the minimum semver-compatible dependency version, not the latest one, so the applications using the library can decide for themselves.
We also should not just update rust dependencies in here willy-nilly. Ideally, we should keep the versions synchronized between this repo and the cosmwasm repo. Otherwise, our huge test suite in cosmwasm runs against different dependency versions than what we actually deploy. Updates aren't always good. They can break stuff.

In general, I'm also not a big fan of dependabot. It creates dozens of small PRs that just become a nuisance. I can see us merging the github-actions part, since that shouldn't be too many PR.

@faddat
Copy link
Contributor Author

faddat commented Feb 18, 2025

The versions aren't synchronized, which is the reason for

But to ensure I understand you correctly: you wish to ensure that dependencies in this repository use the exact same versions as dependencies in cosmwasm?

@chipshort
Copy link
Collaborator

chipshort commented Feb 18, 2025

Yes. To be extra clear, the versions I want to keep in sync are the ones in libwasmvm/Cargo.lock. Those should be the same as the ones in https://github.com/CosmWasm/cosmwasm/blob/main/Cargo.lock (or the lock file of version of cosmwasm we are using in libwasmvm, since we are not necessarily always using cosmwasm's main branch).
The PR you linked is about something completely different.

This is currently done by running cargo update manually in both at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants